Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #38

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Redesign #38

wants to merge 31 commits into from

Conversation

joeyemery
Copy link

GetComposer.org Redesign

So I was having a chat with a good friend of mine, Sam Lambert, about how I wanted to give back to the open source community a few days ago. He told me that the source of GetComposer.org was available to Fork straight from Github and urged me to build a little redesign.

I, of course, agreed straight away. I've been a fan of Composer for a while and use it in almost every project, there isn't an open source technology I'd rather contribute too. So, after a few days (2, I believe) I have succeeded in redesigning your website.

A preview of the new design is available:

Old Site
New Site.

A few quick notes

  • I wrote all the CSS for the redesign using the LESS preprocessor. I've left the source (.less) files inside the repo in case anybody else would like to make a few edits.
  • I also used jQuery for all the javascript, this was mostly because of speed. Writing jQuery code is too easy.
  • The redesign is most likely not bugfree. I've tested as much as I can, in as many places as I can, but I cannot guarantee 0 bugs. However, if people who spot bugs report an issue on my forked repo, I'll fix it and push the changes straight back to you guys!
  • Reponsive design! Woo. (Check on different devices, or simply resize your browser)

What I've edited

I mostly only played with the stuff inside /web and /templates. Any changes I made to other files have likely been reverted (I edited the controllers at one point to interact with the GitHub API through PHP, but replaced this with AJAX later on!)

Github API

You'll notice on the home page there's a little "Latest commit" section. This is done using GitHubs API and a little bit of Javascript/Ajax. However, in order for this to work I had to register the demo domain (composer.pagodabox.com) as an Application within my Github account. I've also done the same for your domain getcomposer.org (So it should work straight of out the box), if you need any help with this, or would like me to delete that application when you make your own I'm contactable at: joey.emery@gmx.com.

Future Changes

I will be likely editing this design quite a few times in the future, fixing bugs, adding features etc, so I'll keep you posted!

My Website.

@stof
Copy link
Contributor

stof commented Mar 15, 2013

I don't like the gray color for the text of the documentation. I find it hard to read as there is not enough contrast with the background

@@ -8,3 +8,4 @@ web/Composer-Setup.exe
web/book.pdf
cache/
silex.log
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use a local ignore instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I'm quite new to Git :|

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeyemery
Copy link
Author

Heads up for anyone viewing now: The Github API powered "Latest Commit" isn't working because I've hit the rate limit. Never expected this to happen. I'm now going to see if I can find a way to cache the most recent commit, if anyone has any suggestions do give me a shout!

@stof
Copy link
Contributor

stof commented Mar 15, 2013

@joeyemery the rate limit is per IP, so people reviewing can see the page properly until they reach it too (i.e. doing 60 unauthenticated calls per hour)

IMO, the link to the download page should be more visible on the homepage.

And on a side note, I find it weird to see Redesign by Joey Emery in the footer of all pages whereas the name of the authors of Composer is only displayed on the homepage...

@joeyemery
Copy link
Author

Yeah, I think I'm going to make the link to download a lot more prominent.
And good point, I totally never thought of that. I just bunged my name into the footer at the end (it's become a routine haha). I'll sort this out too!

On 15 Mar 2013, at 15:56, Christophe Coevoet notifications@github.com wrote:

@joeyemery the rate limit is per IP, so people reviewing can see the page properly until they reach it too (i.e. doing 60 unauthenticated calls per hour)

IMO, the link to the download page should be more visible on the homepage.

And on a side note, I find it weird to see Redesign by Joey Emery in the footer of all pages whereas the name of the authors of Composer is only displayed on the homepage...


Reply to this email directly or view it on GitHub.

@joeyemery
Copy link
Author

I think all the fixes are in now, I can't be sure. Couldn't work on this project for a while due to lack of time. If you guys see anything else that's broken, give me a shout! Cheers.

@joeyemery joeyemery closed this Apr 12, 2013
@joeyemery joeyemery reopened this Apr 12, 2013
@danhunsaker
Copy link

In Chrome 26.0.1410.64 m (currently most recent version) the Download "button" background doesn't occupy the full height of the "button", even to the extent that the others do. It currently cuts off just above the baseline of the text.

image

I suspect that's not the desired styling.

Oh, and did you know that you can change where PagodaBox looks for your document root? In the Boxfile, just add document_root: web/ under web1. That will automatically make the other stuff in the root inaccessible via the web, and remove the web/ portion from the URL, making things cleaner all around. 😀

@joeyemery
Copy link
Author

@danhunsaker Thanks very much! I think I broke this while trying to fix something else in my last commit, I'll get onto it. Cheers :)

@clemherreman
Copy link

Great work, but can you please please put the one-liner install curl code on the homepage. That's would be really great :). Can't count how many time I went there to find it.

@joeyemery
Copy link
Author

So... It's been a while?

@nils-werner
Copy link

I am a bit confused why some boxes show up as lavender while most of the site is in grey/blue...

@gabrielbull gabrielbull mentioned this pull request Mar 11, 2014
<div id="get_started" class="button_block">
<a href="{{ path('docs.view', {page: '00-intro.md'}) }}"><span class="icon">Y</span>Getting Started</a>
</div>
<p class="margintop marginbottom"><span>Composer</span>, written by <a href="#">Nils Andermann</a>, <a href="#">Jordi Boggiano</a> and many <a href="#">community contributors</a>, is an <span>open-source technology</span> licensed under the <a href="#">MIT license</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last name's Adermann ;-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry man, haha!

@yixinrock
Copy link

I really like the new design, good job boy 👍

@joeyemery
Copy link
Author

@wyixin Thank you very much! I don't think it'll actually be used, but it was a lot of fun to make regardless.

@hazbo
Copy link

hazbo commented Jun 13, 2014

This should be used it's awesome!

@prisis
Copy link

prisis commented Dec 11, 2014

Some updates on this?

@joeyemery
Copy link
Author

@prisis What do you mean? I left it there for people to use and they chose not to. I'd be happy to fix the issues that people have spoke about above if I thought I wouldn't be wasting my time.

@prisis
Copy link

prisis commented Dec 16, 2014

@joeyemery I have not spoken directly to you, i was only interested if composer will get a new page :)

@joeyemery
Copy link
Author

@prisis Then you might not want to comment on my pull request?

@prisis
Copy link

prisis commented Dec 16, 2014

Did my question kill you? really...

@DrGirish1978
Copy link

I like the new design of info

@ghost
Copy link

ghost commented Oct 14, 2018

I am also in favour of a new design. A design that looks old gives a bad image of the technology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet