Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close style tags to avoid colour bleed #11972

Merged

Conversation

fredden
Copy link
Contributor

@fredden fredden commented May 11, 2024

When I ran composer require vendor/package:version in order to get a specific version of a package, I noticed that the colour of the "normal" text was different from when I ran composer require vendor/package. I have tracked this down to an unterminated Symfony style tag used in the warning message about specifying a "too strict" restraint. I then scanned all of src/ and found one other instance of this. This pull request fixes both instances.

Screenshot_2024-05-11_20-01-54

@Seldaek Seldaek merged commit ede152b into composer:main May 12, 2024
18 of 20 checks passed
@Seldaek
Copy link
Member

Seldaek commented May 12, 2024

Nice thanks

@Seldaek Seldaek added this to the 2.7 milestone May 12, 2024
@Seldaek Seldaek added the Bug label May 12, 2024
@fredden fredden deleted the bugfix/close-symfony-console-style-tags branch May 13, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants