Detect other PSR violations where namespace is missing or not a subnamespace of configured one #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrinsFrank
force-pushed
the
add-missing-strict-psr-violations
branch
2 times, most recently
from
d1fb66b
to
3ee697c
Compare
PrinsFrank
force-pushed
the
add-missing-strict-psr-violations
branch
from
3ee697c
to
9956a25
Compare
…ilently passing if valid classes are found, will only show up when requesting PSR violations)
PrinsFrank
commented
Apr 30, 2024
| @@ -216,10 +216,6 @@ private function filterByNamespace(array $classes, string $filePath, string $bas | |||
| $realSubPath = substr($realSubPath, 0, $dotPosition === false ? PHP_INT_MAX : $dotPosition); | |||
|
|
|||
| foreach ($classes as $class) { | |||
| // silently skip if ns doesn't have common root | |||
There was a problem hiding this comment.
This check was explicitely here, but looking at the code it can be handled as a rejectedClass instead as it gets silently ignored anyway if at least one valid class is found. Then it can be used when checking with --strict-psr. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes composer/composer#11957
To get warnings about missing namespaces or non-common namespaces in Composer when running with --strict-psr, classes shouldn't be skipped before checking their namespace if they don't have a common root.