Mark published port as string #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2022
glours
force-pushed
the
mark-published-port-as-string
branch
from
44ea6de
to
95a6541
Compare
ulyssessouza
approved these changes
Sep 22, 2022
EricHripko
approved these changes
Oct 15, 2022
align the specification between short and long port syntax Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
mark-published-port-as-string
branch
from
95a6541
to
5c5d43f
Compare
Co-authored-by: Eric Hripko <eric@hripko.com> Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
mark-published-port-as-string
branch
from
438125b
to
0c5f3d8
Compare
ndeloof
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update the
ports.publishedattribut description to explicitly indicate that a string format is expected, as the specification use the Yaml unquoted string feature some user may implicitly assume that only integer value are allowed.Which issue(s) this PR fixes:
Fixes #262 and link to docker/compose#9306