Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FS-4353:Auction-costs_inccorect_text #519

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

FS-4353:Auction-costs_inccorect_text #519

wants to merge 7 commits into from

Conversation

Karunred
Copy link

@Karunred Karunred commented May 3, 2024

Description

Auction Costs and Content change

Check the content “Commissioning an independent survey to identify refurbishment needed to meet minimum stand”

Change text 'stand' to 'standards'

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually checked the web page

Checklist:

  • My changes do not introduce any new linting errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and versioning
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased onto main and there are no code conflicts
  • I have checked deployments are working in all environments
  • I have updated the architecture diagrams as per Contribute.md
image

@Karunred Karunred changed the title Auction-costs_inccorect_text FS 4353 Auction-costs_inccorect_text May 7, 2024
@Karunred Karunred changed the title FS 4353 Auction-costs_inccorect_text FS-4353:Auction-costs_inccorect_text May 7, 2024
nuwan-samarasinghe
nuwan-samarasinghe requested changes May 7, 2024
View reviewed changes
Copy link

@nuwan-samarasinghe nuwan-samarasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts are there

tferns
tferns previously approved these changes May 7, 2024
View reviewed changes
hamzabinkhalid and others added 4 commits May 7, 2024 13:21
@hamzabinkhalid
- Added the form header title/name where it was missing
5a70176
@NarenderRajuB
FS-4348: Add HSRA application guidance section for all questions temp…
46426ca 
…late (#518)

* renamed hsra to hsra_r1

* update docker filer for hsra json

---------

Co-authored-by: Narender Bongoni (standard user) <narenderbongoni1@DLUHC3945.local>
@nuwan-samarasinghe
fixing form definition of the hsra fund's declaration form title (#517)
c143048 
merging since @rayhan15243  approved the PR
@nuwan-samarasinghe
FS-4383 fix declaration checkbox (#522)
6b3ff39 
since got approval merging into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuwan-samarasinghe nuwan-samarasinghe nuwan-samarasinghe approved these changes

@tferns tferns tferns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Karunred @nuwan-samarasinghe @tferns @hamzabinkhalid @NarenderRajuB