-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can now add footer from the designer #153
base: main
Are you sure you want to change the base?
Conversation
import React, { MouseEvent } from "react"; | ||
import { DataContext } from "../context"; | ||
import randomId from "../randomId"; | ||
import FooterEdit from "./footer-edit"; | ||
|
||
type Props = {}; | ||
|
||
type State = { | ||
showAddFooter: boolean; | ||
footerInput?: any; //TODO: type | ||
id?: string; | ||
}; | ||
|
||
class FootersEdit extends React.Component<Props, State> { | ||
static contextType = DataContext; | ||
constructor(props) { | ||
super(props); | ||
this.state = { | ||
showAddFooter: false, | ||
footerInput: undefined, | ||
id: "", | ||
}; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a duplicate of an already existing file in the same folder? they seem to be doing the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a q for my own curiosity!
Is this still relevant @adamdavies1 - looking through all opens prs |
@tferns So its not a required change, its a change i was working on in my spare time to start to get the designer up to date. Lets hold fire for now until we get all the rest done |
Sounds good lets convert to draft till we're ready to work on this again 👍 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.
Add a section to the designer for adding footer data to the form.
This leads to a new section for adding the new footers to the form data
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.
Before PR's can be merged they will need to be tested by QA and approved where
applicable. To flag the change to QA assign @XGovFormBuilder/qa as one of the reviewers.
Checklist: