BUG: Fixed multi-value argument parsing #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
fix-multi-value-cmdline-arg-parsing
branch
2 times, most recently
from
dc801f9
to
acc4baa
Compare
|
Now that we have testing on all three platform (along with automatic upload of packages as GitHub release when integrated into master), we will get a better idea. Thanks for your patience. |
|
xref #11 |
jcfr
force-pushed
the
fix-multi-value-cmdline-arg-parsing
branch
from
acc4baa
to
dad68fa
Compare
|
Topic rebase against current master |
jcfr
force-pushed
the
master
branch
5 times, most recently
from
9b578a5
to
e70f8b5
Compare
When a multi-value argument was passed to the command-line parser, all subsequent parameters were considered part of the argument. The root cause of the problem was that the check that compared a parameter to a known argument was incorrect: the parameter name contained the prefix (--argname) and this string was searched among argument names (such as argname). Fixed by parsing each parameter after a multi-value argument. If a known argument is found, it is not added to the multi-value argument.
jcfr
force-pushed
the
fix-multi-value-cmdline-arg-parsing
branch
from
dad68fa
to
968733d
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a multi-value argument was passed to the command-line parser, all subsequent parameters were considered part of the argument.
The root cause of the problem was that the check that compared a parameter to a known argument was incorrect: the parameter name
contained the prefix (--argname) and this string was searched among argument names (such as argname).
Fixed by parsing each parameter after a multi-value argument. If a known argument is found, it is not added to the multi-value argument.