Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load contents max #11

Closed
wants to merge 5 commits into from
Closed

Load contents max #11

wants to merge 5 commits into from

Conversation

tetron
Copy link
Member

@tetron tetron commented Jul 31, 2018

Peter Amstutz added 2 commits July 30, 2018 22:44
@jmchilton jmchilton self-assigned this Jan 24, 2019
@jmchilton
Copy link
Contributor

Added a conformance test but cwltool fails it... I'll continue to look into this 😢. If my conformance test proves unhelpful feel free to strip it out.

@jmchilton
Copy link
Contributor

Switched my tests around locally and it doesn't seem like cwltool is truncating this down - I find some code paths where it attempts to but maybe this circumvents them somehow or maybe I don't know what I'm doing.

cwltest --test conformance_tests.yaml -n 191 -- --enable-dev
Test [191/209] Test loadContents maximum size.
Test failed: cwl-runner --enable-dev --outdir=/var/folders/78/zxz5mz4d0jn53xf0l06j7ppc0000gp/T/tmp80afEK --quiet tests/wf-loadContents5.cwl tests/empty.json
Test loadContents maximum size.
Compare failure expected: {
    "contains_b": false,
    "size": 1048576
}
got: {
    "contains_b": true,
    "size": 1048577
}
caused by: failed comparison for key 'contains_b': expected: false
got: true
0 tests passed, 1 failures, 0 unsupported features

@jmchilton
Copy link
Contributor

We agreed at the 2019 Winter Boston meeting to delay increasing this limit till past 1.1 and instead clarify error conditions occur at the current limit (WIP at common-workflow-language/common-workflow-language#822).

@mr-c
Copy link
Member

mr-c commented Jul 28, 2020

In CWL v1.2.0-dev5, CWL expressions can create larger Files, but the limit for reading remains. Users should create standalone tools/scripts if they need access to more than 64KiB.

@mr-c mr-c closed this Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants