Enforce that Array[Type]+ are non-empty #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 93.70% 93.93% +0.22%
==========================================
Files 3 3
Lines 667 692 +25
Branches 196 203 +7
==========================================
+ Hits 625 650 +25
Misses 17 17
Partials 25 25
Continue to review full report at Codecov.
|
mr-c
force-pushed
the
array_non_empty_enforce
branch
from
753c927
to
800b579
Compare
mr-c
commented
Feb 16, 2022
Comment on lines
+208
to
+210
| arguments: | ||
| - valueFrom: ${if (inputs.counts_txt.length == 0) {throw "counts_txt must | ||
| contain at least one item.";} else { return "";}} |
There was a problem hiding this comment.
Total hack. Doesn't change the command line if the array has at least one item. Throws a javascript exception if the array is empty, effectively avoiding execution of the tool if the input is malformed.
mr-c
force-pushed
the
array_non_empty_enforce
branch
from
800b579
to
faf2b98
Compare
mr-c
force-pushed
the
array_non_empty_enforce
branch
from
faf2b98
to
6b0ac1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/openwdl/wdl/blob/main/versions/1.1/SPEC.md#arrayx
Only enforced for WDL Task inputs for now.
For Workflow inputs we will have to synthesize a new step to do the checking
Uses a hack from common-workflow-language/common-workflow-language#907