Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STT 1.4.0 - CommonVoice 12 #168

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

wasertech
Copy link

@wasertech wasertech commented Mar 5, 2023

What about we keep commonvoice-fr/DeeepSpeech/ as it is and simply add commonvoice-fr/STT/ instead?

I've started from my branch stt140-cv9 which produced my latest models so I know it works. I updated it to use CV12 but that's basically it.

There are still some points I want to address before I train my next models so that's why it's still a draft but let me know if you already want to merge this new directory and let me update it later.

It's now much easier to compare the differences between DeepSpeech and STT.

❯ diff --recursive DeepSpeech STT

Checkout deepspeech-stt.diff

@wasertech
Copy link
Author

wasertech commented Mar 5, 2023

I would still like to:

But we can do those in other PRs.

"""
_logger.info("Creating corpora...")
corpora_data = self._parse_tsv()
+ # FIXME: THIS IS WRONG DONT USE VALIDATED.TSV AS A SOURCE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixme? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your patch ahahha :) I have not touched it.
I'm not even sure why it's there to begin with :')

Copy link
Author

@wasertech wasertech Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no it was added with #121
f62b21b

STT/run.sh Outdated Show resolved Hide resolved
STT/train.sh Outdated Show resolved Hide resolved
@wasertech
Copy link
Author

I updated my patch to reflect commit 13d9316

@wasertech
Copy link
Author

To reflect them all...

@wasertech wasertech marked this pull request as ready for review March 23, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants