-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to "bundles" #64
Draft
marcomontalbano
wants to merge
15
commits into
main
Choose a base branch
from
poc-bundles
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomontalbano
force-pushed
the
poc-bundles
branch
from
April 9, 2024 21:27
9f7852d
to
d543b96
Compare
marcomontalbano
force-pushed
the
poc-bundles
branch
from
May 23, 2024 07:09
4bb429f
to
a713428
Compare
marcomontalbano
force-pushed
the
poc-bundles
branch
from
May 28, 2024 07:08
f32a39b
to
e05ca27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added an attribute
kind
to thecl-add-to-cart
,cl-price
, andcl-availability
components.This new attribute indicates whether the
code
attribute refers to asku
or abundle
(default tosku
).Important
This feature is not fully implement on the
cl-availability
component. Whenkind
is equal tobundle
no information will be displayed and the component will be rendered as an empty box without any size.Checklist