-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toolbar
to PageLayout
component
#628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gciotola
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 well done!
packages/app-elements/src/ui/composite/TopRightToolbar.test.tsx
Outdated
Show resolved
Hide resolved
gciotola
previously approved these changes
Apr 22, 2024
pfferrari
force-pushed
the
add-top-right-toolbar
branch
from
May 13, 2024 09:34
ea209ea
to
53a13ec
Compare
pfferrari
changed the title
Add TopRightToolbar component
Add May 13, 2024
toolbar
to PageLayout
component
gciotola
previously approved these changes
May 14, 2024
marcomontalbano
approved these changes
May 16, 2024
gciotola
approved these changes
May 16, 2024
malessani
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added
toolbar
configuration to thePageLayout
component to provide a simplified and guided way to manage the top right buttons and dropdown of the apps.The new
toolbar
prop added to thePageLayout
component is an object with optionalbuttons
anddropdownItems
keys to respectively define:Button
s.DropdownItem
s inside a company generatedDropdown
.A default responsive behavior is active by default to rearrage the external
Button
s inside the dropdown menu in case of mobile viewport.Example usage
Checklist