Refactor router macros to limit compile-time dependencies #547
Conversation
lib/commanded/commands/router.ex
Outdated
| case Keyword.get(opts, :prefix) do | ||
| nil -> | ||
| nil | ||
| {opts, _bindings} = Code.eval_quoted(opts, [], __CALLER__) |
There was a problem hiding this comment.
Hex docs for the Code.eval_quoted/3 function has the following warning which seems to be applicable here as the usage is within a macro.
Warning: Calling this function inside a macro is considered bad practice as it will attempt to evaluate runtime values at compile time. Macro arguments are typically transformed by unquoting them into the returned quoted expressions (instead of evaluated).
I don't know what this code is supposed to be doing or why it is needed. The macros in this module are already difficult enough to understand without this added complexity.
Can you help me (and other contributors to this code) to understand what is going on.
There was a problem hiding this comment.
Well spotted. I think I managed to rewrite the macro to avoid using eval_quoted.
It was needed to properly handle the case where a function-reference is passed to the by option.
Updated to apply cleanly