Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put aggregate_state into assigns of the pipeline #502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fahchen
Copy link
Contributor

@fahchen fahchen commented Aug 23, 2022

Assign aggregate_state, so that we can write middlewares to do more things about the aggregate_state in the after_dispatch stage.

@jvantuyl
Copy link

jvantuyl commented Jun 2, 2023

This isn't really necessary. If someone wants the :aggregate_state along with other information, they can ask for an :execution_result and pull it out of there.

@fahchen
Copy link
Contributor Author

fahchen commented Jun 15, 2023

This isn't really necessary. If someone wants the :aggregate_state along with other information, they can ask for an :execution_result and pull it out of there.

@jvantuyl In fact, you cannot get the aggregate_state at after_dispatch, you mean you can get it after the entire dispatch is finished, right?

@jvantuyl
Copy link

jvantuyl commented Aug 2, 2023

Oh, I see. I was thinking you meant "after dispatch" semantically. Not the after_dispatch phase of the middleware. Nevermind, I see what you're getting at now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants