Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda: Nidec COMPUTER_BRAKE_ALT safety #1895

Closed
wants to merge 1 commit into from

Conversation

AravindaDP
Copy link

@AravindaDP AravindaDP commented Mar 9, 2024

Safety mode for COMPUTER_BRAKE_ALT used by Honda Clarity PHEV and Honda Fit Hybrid JDM vehicles.

  • define flag

  • add tests

  • fix tx and rx hooks

 - define flag

 - add tests

 - fix tx and rx hooks
@adeebshihadeh
Copy link
Contributor

We've decided the Clarity port isn't worth it to us to upstream - see #20268

@AravindaDP
Copy link
Author

AravindaDP commented Mar 10, 2024

@adeebshihadeh Noted.

Just a quick question. Is decision for Clarity fork because of

a) It needing this alternate safety mode and needing logic change at hondacan.py to accommodate COMPUTER_BRAKE_ALT?

b) Because it needs a proxy panda gateway to copy messages from extra CAN bus? (i.e. Additional H/W requirement/different harness connector)

c) Both of above requirement?

d) Simply because there aren't enough Clarity users irrespective of above complexities? Is there a minimum number of users that warrants a model port being accepted?

As a note I was trying my luck getting Honda Fit Hybrid JDM up streamed. Following is full details.

  1. Both models need this Panda safety mode. If it is not welcomed no matter how many models out their using it, no worries I understand.

  2. Both models need change at hondacan.py to accommodate COMPUTER_BRAKE_ALT in hondacan.py apart from usual model port additions.

  3. I guess Clarity will need Different harness connector. For Honda Fit Hybrid JDM I submitted here: Nidec Harness for Fit Hybrid JDM neo#80 perhaps same might work for Clarity as well. (Along with proxy panda gateway)

However complexities ends there for Honda Fit Hybrid JDM.

It does not need a proxy panda gateway like Clarity.

Thanks a lot for your time.

@adeebshihadeh
Copy link
Contributor

C and D. The calculation in terms of difficulty to get merged here is roughly: new/custom HW > panda code > openpilot code. Requiring two or three of those means we expect to support lots of models and users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants