Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with additions for windows specific installation #837

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

HarmvZ
Copy link
Member

@HarmvZ HarmvZ commented Jun 25, 2019

@jmsmkn Could you please check if the docs build succeeds and the formatting is correct before merging this?

Building the docs fails on my machine with the error:
ModuleNotFoundError: No module named 'djcelery_email'

When I try to install that module it returns:
Could not find a version that satisfies the requirement djcelery_email (from versions: ) No matching distribution found for djcelery_email.

I'm not sure what's going on there but I think that's probably some Windows issue again and it's probably not really useful to spend time on that right now.

@HarmvZ HarmvZ self-assigned this Jun 25, 2019
@HarmvZ HarmvZ requested a review from jmsmkn June 25, 2019 16:34
@jmsmkn
Copy link
Member

jmsmkn commented Jun 25, 2019

The docs generation are failing due to readthedocs/readthedocs.org#4783 and we have an issue on it too (#795). I will double check this when upstream is fixed. This might not happen any time soon so we may need to setup an alternative to pipenv for managing our dependencies.

Copy link
Member

@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         364      364           
  Lines       12106    12106           
=======================================
  Hits        11310    11310           
  Misses        796      796

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb7d73...c7ad6f2. Read the comment docs.

@jmsmkn jmsmkn merged commit b954fb8 into master Jun 25, 2019
@jmsmkn jmsmkn deleted the 'update-docs-for-windows' branch June 25, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants