Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holding directory for IPAdapters #3299

Closed
wants to merge 2 commits into from
Closed

Conversation

fofr
Copy link

@fofr fofr commented Apr 19, 2024

The most popular IPAdapter custom node https://github.com/cubiq/ComfyUI_IPAdapter_plus puts these models into the models/ipadapter directory.

This PR adds that holding directory as a default.

cc @cubiq

@cubiq
Copy link
Contributor

cubiq commented Apr 19, 2024

Ideally you'd also add folder_names_and_paths["ipadapter"] = ([os.path.join(models_dir, "ipadapter")], supported_pt_extensions) to folder_paths.py

@fofr
Copy link
Author

fofr commented Apr 19, 2024

@cubiq Added in 46ffc92

@kaalibro
Copy link

But the extension already supports external directories. I added the ipadapter in extra_model_paths.yaml and it works. Unless I've misunderstood the intent of this PR.

Screenshot 2024-04-20 115014

@fofr
Copy link
Author

fofr commented Apr 20, 2024

The intent of this PR is just to bring IPAdapters inline with other model types.

@mcmonkey4eva
Copy link
Collaborator

This should probably be handled in the IP-Adapter extension?
Or if for whatever reason it's unable to be handled from there, a generic API for it on the comfy side so extension can handle it as-needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants