SDK v50, common module addition #876
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cgsingh33
commented
Dec 14, 2023
•
cgsingh33
commented
- sdk v50
- ibc-go v8
- wasmd v50
- common module
cgsingh33
requested review from
bsrinivas8687 and
dheerajkd30
as code owners
github-actions
bot
added
C:x/rewards
C:x/auction
C:x/lend
C:x/vault
C:x/liquidation
labels
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1415
to
+1422
| for _, m := range a.mm.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.