Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure .scalafmt.conf is correct for Scala 3 sources #118

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

ckipp01
Copy link
Contributor

@ckipp01 ckipp01 commented Mar 2, 2024

This also marks project.git as true to make sure scalafmt doesn't look into any dirs that are ignored.

So it doesn't look like scalafmt is actually enforced at all in the project, but since the file exists, Metals warns when you open since it's technically incorrect for the Scala 3 sources. This just fixes that to make sure Metals users don't get a warning upon opening the project.

This also marks `project.git` as `true` to make sure scalafmt doesn't
look into any dirs that are ignored.
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou changed the title fix: ensure .scalafmt is correct for Scala 3 sources Ensure .scalafmt.conf is correct for Scala 3 sources Jun 1, 2024
@lefou lefou merged commit bd1295a into com-lihaoyi:main Jun 1, 2024
4 checks passed
@lefou lefou added this to the after 0.7.0 milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants