only 'teardown' serializer on connection close. closes colyseus/schem…

…a#95
colyseus · Nov 26, 2020 · 4ba2be5 · 4ba2be5
1 parent 6fa0d82
commit 4ba2be5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "colyseus.js",
-  "version": "0.14.0",
+  "version": "0.14.1",
   "description": "Colyseus Multiplayer Client for JavaScript/TypeScript",
   "author": "Endel Dreyer",
   "license": "MIT",

diff --git a/src/Room.ts b/src/Room.ts
@@ -71,7 +71,8 @@ export class Room<State= any> {
                 return;
             }
 
-            this.onLeave.invoke(e.code)
+            this.onLeave.invoke(e.code);
+            this.destroy();
         };
         this.connection.onerror = (e: CloseEvent) => {
             console.warn(`Room, onError (${e.code}): ${e.reason}`);
@@ -162,9 +163,6 @@ export class Room<State= any> {
     }
 
     public removeAllListeners() {
-        if (this.serializer) {
-            this.serializer.teardown();
-        }
         this.onJoin.clear();
         this.onStateChange.clear();
         this.onError.clear();
@@ -267,6 +265,12 @@ export class Room<State= any> {
         }
     }
 
+    private destroy () {
+        if (this.serializer) {
+            this.serializer.teardown();
+        }
+    }
+
     private getMessageHandlerKey(type: string | number | typeof Schema): string {
         switch (typeof(type)) {
             // typeof Schema