setting latest tag for COLMAP_GIT_COMMIT instead of dev or main
#2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ockerfile set `COLMAP_GIT_COMMIT` to the latest tag, i.e. 3.9.1, otherwise it uses the user provided one Example `docker build --build-arg CUDA_ARCHITECTURES=75 .` `docker build --build-arg COLMAP_GIT_COMMIT=main --build-arg CUDA_ARCHITECTURES=75 .`
behnamasadi
changed the title
COLMAP_GIT_COMMIT) instead of devCOLMAP_GIT_COMMIT instead of dev or main
|
Hello Johannes @ahojnnes, |
|
@behnamasadi Seems like there is also still some other issue? The CI build still fails. |
|
Sorry for my late reply, will investigate it this weekend, thanks for your patience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user doesn't specify any commit id (
COLMAP_GIT_COMMIT) the Dockerfile setCOLMAP_GIT_COMMITto the latest tag, i.e. 3.9.1, otherwise it uses the user provided oneExample
docker build --build-arg CUDA_ARCHITECTURES=75 .docker build --build-arg COLMAP_GIT_COMMIT=main --build-arg CUDA_ARCHITECTURES=75 .