New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new auto_mapper command #1167
base: main
Are you sure you want to change the base?
Conversation
// frame002.png | ||
// ... | ||
// | ||
std::vector<CameraRig> ReadCameraRigConfig(const std::string& rig_config_path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No code changes here; just moved it from below to group all helper functions together.
I like the skip_color_extraction but I am not 100% sure about the logic in the auto_mapper command to be honest. I don't want to encourage people to rely too much on the hierarchical_mapper, which will not work too well when the input consists of internet images, etc. |
I can see the concern about relying too much on auto_mapper. Has worked well enough for me so far since our datasets are more cohesive, but that may not generalize well enough to be broadly used. I can leave the refactoring and the new Either approach is fine by me. |
The new
auto_mapper
command is a convenience command that combines mapper, triangulator, and bundle adjuster as needed based on the provided options. It can do the following:Also, added new option
skip_color_extraction
in bothauto_mapper
andpoint_triangulator
that avoids the call toReconstruction::ExtractColorsForAllImages
after triangulation since that's a pretty slow part of the process (single-threaded only) and is not necessary when we don't care about colors of the sparse point clouds