Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto_matcher command for feature matching #1143

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

anmatako
Copy link
Contributor

auto_matcher is a convenience feature matching command that chooses the best feature matching method based on the given option. The choices in order are:

  1. ImagePairsFeatureMatcher: if the --ImagePairsMatching.match_list_path is set to a valid image pairs file that includes all images in the DB
  2. SpatialFeatureMatcher: if the image pairs file is not given or is malformed in any way and the DB contains GPS priors for the images
  3. ExhaustiveFeatureMatcher: This is a fallback that should always work if neither of the two earlier choices are usable. It is also used when the max matching distance of the spatial matcher is larger than the max distance of images in the DB; this happens because in such a case the spatial matcher devolves to exhausting matching anyway, and leveraging the batches of the exhaustive matcher speeds things up a bit

@@ -176,6 +177,132 @@ int RunAutomaticReconstructor(int argc, char** argv) {
return EXIT_SUCCESS;
}

static bool UseSpatialMatcher(const std::string& database_path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace static with an anonymous namespace.

src/exe/colmap.cc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants