Fix model_cropper not resetting image.num_points3D of cropped_rec (#2557

) * Fix model_cropper not resetting image.num_points3D for cropped_reconstruction * code consistency --------- Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
colmap · May 9, 2024 · eaffee3 · eaffee3
1 parent d84c5b6
commit eaffee3
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/colmap/scene/reconstruction.cc b/src/colmap/scene/reconstruction.cc
@@ -452,8 +452,9 @@ Reconstruction Reconstruction::Crop(
   for (const auto& image : images_) {
     auto new_image = image.second;
     new_image.SetRegistered(false);
-    for (auto& point2D : new_image.Points2D()) {
-      point2D.point3D_id = kInvalidPoint3DId;
+    const auto num_points2D = new_image.NumPoints2D();
+    for (point2D_t point2D_idx = 0; point2D_idx < num_points2D; ++point2D_idx) {
+      new_image.ResetPoint3DForPoint2D(point2D_idx);
     }
     cropped_reconstruction.AddImage(std::move(new_image));
   }