perl plugin: fix Clang compilation by ignoring a warning #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
changed the title
|
Changed title to better describe what is being fixed, and added the required (Fix) label & "ChangeLog" entry. |
eero-t
requested changes
May 8, 2024
|
@mrunge, do you have Linux setup for checking whether Perl plugin has same issue with current Linux Clang / or any other comments on this? (I don't have any Perl dev stuff on my setup, and I'd rather keep it out of it, as I'm rather a Python user. :-)) |
|
Commit title should be also be fixed, to indicate that it's the perl plugin that is being fixed (not clang one). |
A new warning type introduced since clang 12 causes a build failure. Ignore it to fix. https://reviews.llvm.org/D86751 Fixes: collectd#4308
|
@eero-t please re-review |
eero-t
approved these changes
May 20, 2024
|
I am not using the perl plugin, and I'm also not building collectd on a regular basis anymore, so can't add test cases or feedback to this. |
|
@jvsg thank you for your PR, it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: perl plugin: fix Clang compilation by ignoring a warning
Fixes: #4308