feat: [intel_rdt] Added support for LLC misses monitoring event #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksinx
force-pushed
the
intel_rdt_llc_miss
branch
from
e3865d3
to
949c1a3
Compare
aleksinx
force-pushed
the
intel_rdt_llc_miss
branch
from
949c1a3
to
5e218ea
Compare
aleksinx
changed the title
eero-t
reviewed
Mar 25, 2024
aleksinx
force-pushed
the
intel_rdt_llc_miss
branch
from
b3473d7
to
2bde020
Compare
eero-t
reviewed
Mar 26, 2024
aleksinx
force-pushed
the
intel_rdt_llc_miss
branch
4 times, most recently
from
3d597dc
to
846e064
Compare
aleksinx
force-pushed
the
intel_rdt_llc_miss
branch
from
846e064
to
8799589
Compare
eero-t
requested changes
Apr 26, 2024
src/intel_rdt.c
Outdated
Comment on lines
156
to
158
| #if PQOS_VERSION < 40000 | ||
| const enum pqos_mon_event events = group->event; | ||
| #endif |
There was a problem hiding this comment.
This is unnecessary and confuses code. Just remove it and use group->event directly in that one place below.
src/intel_rdt.c
Outdated
Comment on lines
206
to
208
| #if PQOS_VERSION < 40400 | ||
| const struct pqos_event_values *values = &group->values; | ||
| #endif |
There was a problem hiding this comment.
This is unnecessary now. Just use group->values directly in that one place below.
mkobyli
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added llc_miss metric
ChangeLog: intel_rdt: Added support for LLC misses monitoring event