You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Dirty" and "Writeback" help debug IO delay issues, e.g., when we see io-await getting high, with the help of those two metrics it becomes easier to learn if our IOs are stuck on flushing Dirty pages.
So it might be useful to let Collectd include those two metrics.
Changelog: add "Dirty" and "Writeback" with conf option in the memory plugin
ReportDirty option name seems too specific to a single Linux-specific meminfo metric though. IMHO it should be a more generic one telling user that option is about disk IO / usage related memory metrics. Any suggestions?
ReportDirty option name seems too specific to a single Linux-specific meminfo metric though. IMHO it should be a more generic one telling user that option is about disk IO / usage related memory metrics. Any suggestions?
By the way, do not know why format.sh check fails...
I've seen local clang-format to order includes differently form the remote version used by format.sh. Just run the suggested command, and commit the result.
If it is indeed due to different include ordering, see: ce8a26c
Only failing check is for epics plugin, nothing to do with this. Changes are small & fine, only question is about the option name. I'm not completely sure about the new one either, but do not have a good suggestion myself. @octo?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Dirty" and "Writeback" help debug IO delay issues, e.g., when we see io-await getting high, with the help of those two metrics it becomes easier to learn if our IOs are stuck on flushing Dirty pages.
So it might be useful to let Collectd include those two metrics.
Changelog: add "Dirty" and "Writeback" with conf option in the memory plugin