Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPU / GPU temp population for macOS #4146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tapthaker
Copy link

@tapthaker tapthaker commented Nov 1, 2023

Tested this by running locally on one of my Mac instances. This doesn't work for Apple Silicon yet. Still need to figure that out.

ChangeLog: Fix CPU / GPU and Ambiant temperature logging on macOS

mac@xxxxx Documents % tail /Users/mobileci/collectd/data/xxxxx/apple_sensors-ambient/temperature-2023-11-01
1698869736.548,19.582031
1698869796.539,19.570312
1698869856.540,19.554688
1698869916.549,19.472656
1698869976.541,19.699219
1698870036.536,19.542969
1698870096.544,19.636719
1698870156.546,19.531250
1698870216.539,19.675781
mac@xxxxx Documents % tail /Users/mobileci/collectd/data/xxxxx/apple_sensors-cpu/temperature-2023-11-01
1698869736.547,53.437500
1698869796.539,53.437500
1698869856.539,53.562500
1698869916.548,53.625000
1698869976.540,53.500000
1698870036.536,53.437500
1698870096.543,53.687500
1698870156.545,53.937500
1698870216.538,53.437500
1698870276.540,53.375000

Fixes #4070

@tapthaker tapthaker requested a review from a team as a code owner November 1, 2023 20:30
@eero-t
Copy link
Contributor

eero-t commented Nov 24, 2023

Um. This is more like "total conversion", rather than a fix. Because no reason is given why everything had to be changed, I'm wondering whether even a separate plugin would be more appropriate.

@octo
Copy link
Member

octo commented Nov 24, 2023

Thanks for the PR @tapthaker! I think reporting of the GPU temperature is a great extension of this plugin.

This PR seems to remove a bunch of functionality, e.g. "fanspeed" reporting though, which breaks backwards compatibility. Can you reconcile the existing code and your code so all the metrics can be reported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple_sensors plugin not storing metrics
3 participants