forked from googleapis/python-storage
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: allow signed url version v4 without signed credentials (googleap…
…is#356) * Fix: signed_url_v4 to accept credentials without private key. Preserve checks for efficiency in case of neither access_token nor service_account_email are provided. Fix: tests v4 with token to take into account not Signing credential class. * fix typo: 2 new lines before new test class * fix doc: Improve docstring to explain the use of the access_token AND the service_account_email, or the signer email. * fix: test coverage with the new IF branch * lint Co-authored-by: Tres Seaver <tseaver@palladion.com> Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com> Co-authored-by: Frank Natividad <franknatividad@google.com>
- Loading branch information
Showing
2 changed files
with
58 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters