[TPC-H] Simplify Dask queries and avoid .query and .apply
#1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
commented
Feb 2, 2024
| @@ -839,6 +841,7 @@ def query_16(dataset_path, fs): | |||
| supplier = dd.read_parquet(dataset_path + "supplier", filesystem=fs) | |||
|
|
|||
| supplier["is_complaint"] = supplier.s_comment.str.contains("Customer.*Complaints") | |||
| # FIXME: We have to compute this early because passing a `dask_expr.Series` to `isin` is not supported | |||
There was a problem hiding this comment.
XREF: dask/dask-expr#834
There was a problem hiding this comment.
You could rewrite to a merge, but not blocking
|
Honestly, I'm pretty confused by CI, but I don't touch any of these tests in here, so this appears to be unrelated. |
phofl
reviewed
Feb 2, 2024
milesgranger
approved these changes
Feb 2, 2024
phofl
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.