Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK GET request Query Parameter Bug: #23

Open
wants to merge 1 commit into
base: 1.1.5
Choose a base branch
from

Conversation

naveena-maplelabs
Copy link
Collaborator

  • In sdk, query parameters for certain requests are obtained as
    list of strings.
  • But while sending the params to API, values expected is comma
    separated strings.
  • This conversion is not happening and API call fails or provide
    incorrect responses.

Uploaded sample code for principals_controller.py file

* In sdk, query parameters for certain requests are obtained as
list of strings.
* But while sending the params to API, values expected is comma
separated strings.
* This conversion is not happening and API call fails or provide
incorrect responses.
> Uploaded sample code for principals_controller.py file
Copy link
Collaborator

@pyashish pyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, fix it in master not in 1.1.5 .. we'll have to come up with generic fix across branches for patching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants