Exception has been caught and custom error implemented while processing the Rest API via cmdlet #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the Rest API. If the error notification is not as per the desired JSON format, then validation has been done and custom exception implemented
pyashish
requested changes
Mar 16, 2022
| } | ||
| catch { | ||
|
|
||
| $errorMsg = "Invalid JSON format. Unable to parse the JSON string..." |
There was a problem hiding this comment.
The error message could be better. Developer needs to understand what the error is, Can you print the response ?
"Unable to read incoming request from server" : $Response
Also test these scenarios:
- API which returns Error
- Try API which is not in the system
- the powershell lint is failing on unrelated error, can you fix that ?
added 2 commits
March 17, 2022 15:05
The following PR comments incorporated Customer error description modified Log path included in the custom error Priting both custom error and valid error response from the backend
Alignment done to avoid pester script validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception has been caught and custom error implemented while processing the Rest API via cmdlet. If the error notification is not as per the desired JSON format, then validation has been done and custom exception implemented