Routes again #26
Closed
Routes again #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the tween, map change, and activity change actions, which will be used by routesRestore the Action System Includes the tween, map change, and activity change actions, which will be used by routes
Routes will need it, and borrow checker doesn't want it coming from MapListPass current map hash down again
These are used for tweens for routes
Currently has some issues with the new Global system
I foolishly used Global when I meant to use Global, since I selected Global when quickfixing to lazily add an import instead of Global, like I should have. Oh, and bonus clippy fix
This lets you queue adding things to a scene after changing the activity. Theoretically. Doesn't quite work now... Route command will swap to correct activity first, and then fail to add the route if activity was changed. Might need to fix when ActivitySwapAction's is_done returns true.
CommandBuffers are out. Route specific actions are in. Sadly can't get the entity to select them properly, since the map may not be set up yet, so we can't reserve the entity to select. We can, however, make a route specific action. Also, wait for maps to exist before attempting to add a route. We can do this by ending the ActivitySwapAction after a map is loaded.
cohaereo
requested changes
May 20, 2024
| @@ -296,20 +309,316 @@ impl ComponentPanel for Beacon { | |||
| }); | |||
|
|
|||
| // TODO(cohae): Reimplement tween rotation | |||
|
|
||
| if let Some(map) = maps.current_map_mut() { | ||
| let e = map.scene.spawn(( | ||
| Route { |
There was a problem hiding this comment.
Add a Label and Icon component so it looks nice in the inspector/outliner
| @@ -112,7 +119,7 @@ impl Renderer { | |||
| self.draw_shading_pass(scene); | |||
| self.draw_transparents_pass(scene); | |||
|
|
|||
| draw_utilities(self, scene, resources) | |||
| draw_utilities(self, scene, resources, current_hash) | |||
There was a problem hiding this comment.
Map hash should not be passed into the renderer.
Is there a way we can identify local nodes without needing information about maps (besides the scene)?
If not, then we might need to pass a Map into the renderer instead of a Scene
|
Will be picked up by me post-0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to restore routes. The Activity action doesn't seem to be working, and globals do not work well. Swapping maps will sometimes get rid of the route, and nodes may disappear while traversing.