Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] Update the navigation panel in proposal route #638

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

varunks99
Copy link

This fixes #636.

Bug description

The navigation bar on the left-hand side of the proposal related pages is not properly updated.

Root cause

The 'active' class for the navigation panel is defined by the respective props. The props passed for the proposal component was incorrect/incomplete.

Solution description

I added the state {org:true} in the ProposalEditor component and passed it as props to the navigation panel.
Now when clicking on the "propose an idea button", the "Organization" tab is highlighted and active as should be.

Screenshots

Screenshot

@AuraOfDivinity @jaskiratsingh2000

@jaskiratsingh2000
Copy link
Member

hey @AuraOfDivinity and @ksraj123 can we review this up?

Copy link
Collaborator

@AuraOfDivinity AuraOfDivinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @varunks99 . Few concerns on my end.

  1. The background color of the navbar is not consistent. We still have the white color appearing over some portions. Please find the cause of this and fix it.
  2. The nav bar should take up the entire width of the navigation panel(Check and compare the implementation of this with the navbar implementation of the dashboard.)

Please let me know if you need further clarification.

@varunks99
Copy link
Author

varunks99 commented Oct 4, 2020

@AuraOfDivinity

  1. The background color of the navbar is not consistent. We still have the white color appearing over some portions. Please find the cause of this and fix it.

Are you talking about the Jitsi Meet and Logout buttons?

  1. The nav bar should take up the entire width of the navigation panel(Check and compare the implementation of this with the navbar implementation of the dashboard.)

Could you please elaborate on this a little? As I was not able to reproduce this issue.

@AuraOfDivinity
Copy link
Collaborator

image

@varunks99 Please have a look at the parts I have highlighted in red and compare it with the nav panel on the following image. They should basically look similar.

image

Notice that the nav panel takes up the entire width and the background color of the navbar is consistent.

Fix nav panel width and inconsistent background colour for proposal editor page
@varunks99
Copy link
Author

@AuraOfDivinity, I fixed it now.

Screenshot (238)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants