Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 379 #381

Closed
wants to merge 10 commits into from
Closed

Fix issue 379 #381

wants to merge 10 commits into from

Conversation

thenewguy
Copy link
Contributor

@thenewguy thenewguy commented Nov 11, 2020

Resolves #379

@thenewguy
Copy link
Contributor Author

@vsalvino Good morning Vince. Not sure what all you want along with this. But these blocks let me customize appropriately

@thenewguy thenewguy marked this pull request as ready for review November 16, 2020 15:36
@thenewguy
Copy link
Contributor Author

Any chance for merging this? It just adds some blocks that makes customization easier

fixes error in coderedcms setup command: 'install_requires' must be a
string or list of strings containing valid project/version requirement
specifiers; .* suffix can only be used with `==` or `!=` operators
@vsalvino
Copy link
Contributor

Hello - thanks for doing this work. Sorry, but we have been debating heavily over the best way to improve the navbar.

In the 4.0 release, we are going to provide the ability to disable the built-in navbar, and also provide a pre-built custom navbar. Basically we are going to discourage use of the built-in navbar for professional or custom sites. Follow the example in the upcoming "pro" project here: (look in website/models.py and website/templates/website/): https://github.com/coderedcorp/coderedcms/tree/main/coderedcms/project_template/pro

Given all of that, I am not going to merge this in, but I appreciate your support!

@vsalvino vsalvino closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional blocks for navbar template customization
2 participants