Check for new member webhook config names #950
Conversation
mfrancisc
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
sbryzak
as code owners
Hello, @mfrancisc From this search query, we can see occurrences in this PR and in PR #934 |
|
thank you @rsoaresd ! I wrote "Flaky" in there, but I see they failing again with same error :) , so maybe related to my changes, I'm running those migration tests locally as well ! |
I was able to reproduce it locally with this code change |
|
/retest updated script |
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| OWNER_AND_BRANCH_LOCATION=codeready-toolchain/toolchain-cicd/master | |||
| OWNER_AND_BRANCH_LOCATION=mfrancisc/toolchain-cicd/removetoolchainclusterres | |||
mfrancisc
changed the title
| @@ -263,7 +263,7 @@ get-and-publish-operators: clean-e2e-files get-and-publish-host-operator get-and | |||
| # The reason is that when the host operator is installed, then the logic creates ToolchainConfig CR which | |||
| # defines that the webhook should be deployed from the first member instance (and not from the second one). | |||
| # This is important to set before the member operators are installed, otherwise, it can lead to flaky e2e tests. | |||
| get-publish-install-and-register-operators: get-and-publish-host-operator setup-toolchainclusters create-host-resources get-and-publish-member-operator | |||
| get-publish-install-and-register-operators: get-and-publish-host-operator get-and-publish-member-operator setup-toolchainclusters create-host-resources | |||
There was a problem hiding this comment.
this is needed since now we are deploying the toolchaincluster-member SA from the member-operator deployment, thus we need to run setup-toolchainclusters only after deploying the member operator deployment.
In order to invert those make targets I had todo some changes in member operator, see paired PR for those.
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR uses the new cicd scripts without the toolchaincluster resource creation and checks for the new member operator webhook config names.
The renaming is needed in order to reshuffle the make targets so that :
Related PR: codeready-toolchain/toolchain-cicd#107
Paired with: