Update controller-runtime to v0.15 #409
Conversation
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
sbryzak and
mfrancisc
as code owners
| // using latest commit from 'github.com/openshift/api branch release-4.14' | ||
| github.com/openshift/api v0.0.0-20231117205818-971e4ba78c9a | ||
| k8s.io/api v0.27.2 | ||
| k8s.io/apimachinery v0.27.2 | ||
| k8s.io/code-generator v0.27.2 |
There was a problem hiding this comment.
I thought that we wanted to support OpenShift 4.15 right away, or is the upgrade to OpenShift 4.15 supposed to be done in the following PR(s)?
There was a problem hiding this comment.
correct, upgrade to 4.15 would be in the following ones so it is easy to update and review
ranakan19
changed the title
|
| @@ -6,8 +6,8 @@ image:https://codecov.io/gh/codeready-toolchain/api/branch/master/graph/badge.sv | |||
| == Building | |||
| Requires: | |||
|
|
|||
| * Go version 1.18.x (1.18.8 or higher) - download for your development environment https://golang.org/dl/[here]. | |||
| * Operator SDK v1.23.0 - download for your development environment https://v1-23-x.sdk.operatorframework.io/docs/installation/#install-from-github-release[here] | |||
| * Go version 1.20.x (1.20.11 or higher) - download for your development environment https://golang.org/dl/[here]. | |||
There was a problem hiding this comment.
readme was outdated - this just fixes that. Not related to the documentation of the changes introduced in this PR
| k8s.io/apimachinery v0.27.2 | ||
| k8s.io/code-generator v0.27.2 | ||
| k8s.io/gengo v0.0.0-20220902162205-c0856e24416d | ||
| k8s.io/kube-openapi v0.0.0-20230501164219-8b0f38b5fd1f |
There was a problem hiding this comment.
Just a Thought , Do we need to discuss resolve the update to kube-openapi version as i see PR from francesco https://github.com/codeready-toolchain/api/pull/421/files updating it to the latest , and here it updates to some previous versions ? wont that be conflicting or may be just duplication of work?
There was a problem hiding this comment.
Thanks @fbm3307 - I checked the version for the kube-openapi for controller-runtime v0.15 is https://github.com/kubernetes-sigs/controller-runtime/blob/release-0.15/go.mod#L71 the same as here.
I've responded on the other PR to know what is the reason to update to the latest version. I'd like to keep the dependencies in sync unless there is a need otherwise.
Description
DO-NOT Merge
(All the PRs related to version updates need to be merged at once, but these PR are for early feedback so that there are not a lot of changes to review at once)
changes wrt - https://issues.redhat.com/browse/SANDBOX-525
Updates:
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? n/a
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.
CRD yaml make generate updates when upgrading controller-gen in api host-operator#994
CRD yaml make generate updates when upgrading controller-gen in api member-operator#546