fix(socket): use xdgBasedir.runtime instead of tmp #3304
Merged
+184
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3304 +/- ##
==========================================
+ Coverage 58.95% 59.21% +0.26%
==========================================
Files 35 35
Lines 1703 1709 +6
Branches 374 379 +5
==========================================
+ Hits 1004 1012 +8
+ Misses 561 559 -2
Partials 138 138
Continue to review full report at Codecov.
|
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
from
8604498
to
8b4a577
Compare
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
3 times, most recently
from
f883ab0
to
acfd152
Compare
jsjoeio
commented
May 10, 2021
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
2 times, most recently
from
3365791
to
4ec028a
Compare
code-asher
requested changes
May 11, 2021
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
2 times, most recently
from
dfe8b7d
to
dd8f709
Compare
jsjoeio
commented
May 11, 2021
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
from
752d19d
to
9c462c0
Compare
code-asher
approved these changes
May 12, 2021
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
from
9c462c0
to
f1969bb
Compare
jsjoeio
added
the
squash when passing
|
Moving to draft because I need to write more tests (new change decreases -0.15%). We want increases! |
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
from
0453e21
to
9af2112
Compare
jsjoeio
commented
May 12, 2021
Comment on lines
+16
to
+19
| return () => ({ | ||
| data: "/home/envPath/.local/share", | ||
| config: "/home/envPath/.config", | ||
| temp: "/tmp/envPath/runtime", |
There was a problem hiding this comment.
For whatever reason, when I extract this object into a variable and pass in to the mock, it doesn't work 🤷♂️
Comment on lines
+33
to
+38
| jest.mock("xdg-basedir", () => ({ | ||
| data: "/home/usr/.local/share", | ||
| config: "/home/usr/.config", | ||
| runtime: "/tmp/runtime", | ||
| })) | ||
| const getEnvPaths = require("../../../src/node/util").getEnvPaths |
There was a problem hiding this comment.
I have to do this because of: jestjs/jest#2582 (comment)
jsjoeio
removed
the
squash when passing
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
2 times, most recently
from
faf12cb
to
4da1388
Compare
code-asher
approved these changes
May 13, 2021
jsjoeio
force-pushed
the
jsjoeio/fix-tmp-path
branch
from
4da1388
to
46fe77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue:
discarding socket connection: EACCES: permission denied, unlink '/tmp/code-server/tls-proxy'by using the
xdgBasedir.runtimepath instead of/tmp/code-server/tls-proxy.Changes
runtimetogetEnvPathsgetEnvPathstmpdirinsocket.tsrefactor: use paths.runtime in socket proxyPipe
Screenshots
Checklist
Fixes #2200