Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker up command #2821

Merged
merged 2 commits into from Jul 25, 2023
Merged

fix: docker up command #2821

merged 2 commits into from Jul 25, 2023

Conversation

assimhabeek
Copy link
Contributor

@assimhabeek assimhabeek commented Jul 18, 2023

Description

Remove name which is not supported by most docker-composer versions.

Video or Image

Related Issue(s)

Fixes #2820

@vercel vercel bot temporarily deployed to Preview – platform July 18, 2023 10:58 Inactive
@vercel vercel bot temporarily deployed to Preview – platform-api July 18, 2023 11:08 Inactive
Copy link
Member

@webberwang webberwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have version: '3.8' specified?

@assimhabeek
Copy link
Contributor Author

assimhabeek commented Jul 24, 2023

don't we have version: '3.8' specified?

The file version doesn't matter, the plugin version that really does. the new docker compose project (v2) which supports the name attribute is used like this docker compose instead of docker-compose
https://docs.docker.com/compose/reference/

@vercel vercel bot temporarily deployed to Preview – platform-api July 24, 2023 17:12 Inactive
@vercel vercel bot temporarily deployed to Preview – platform July 24, 2023 17:19 Inactive
@vercel vercel bot temporarily deployed to Preview – platform-api July 24, 2023 17:29 Inactive
@vercel vercel bot temporarily deployed to Preview – platform July 24, 2023 17:36 Inactive
@webberwang webberwang merged commit af69962 into master Jul 25, 2023
6 checks passed
@webberwang webberwang deleted the 2820-fix-docker-up branch July 25, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker up command field due to name key in docker-composer file
2 participants