Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Some small typos and modifications in libraries/time.rst #8884

Merged
merged 3 commits into from
May 27, 2024

Conversation

obozdag
Copy link
Contributor

@obozdag obozdag commented May 10, 2024

Description
Some small typos and modifications in libraries/time.rst

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Some small typos and modifications in libraries/time.rst
@kenjis kenjis added the documentation Pull requests for documentation only label May 10, 2024
$time < 1 minute Now
=============================== =================================

The exact language used is controlled through the language file, **Time.php**.
The result strings are coming from the language file, **app/Language/{locale}/Time.php**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, there is no app/Language/{locale}/Time.php.

Change last sentence in humanize() in libraries/time.rst
Co-authored-by: kenjis <kenji.uui@gmail.com>
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit b1e2366 into codeigniter4:develop May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants