Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redis cache handler deleteMatching() not working when a prefix is being used #8878

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TeamTizo
Copy link

@TeamTizo TeamTizo commented May 9, 2024

deleteMatching wasn't working for Redis cache when a prefix was being used. adding prefix here fixed the issue.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

deleteMatching wasn't working for Redis cache when a prefix was being used.  adding prefix here fixed the issue.
@TeamTizo TeamTizo changed the title fix Redis cache handler deleteMatching() not working when a prefix is being used fix: Redis cache handler deleteMatching() not working when a prefix is being used May 9, 2024
@kenjis
Copy link
Member

kenjis commented May 9, 2024

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

@kenjis kenjis added tests needed Pull requests that need tests bug Verified issues on the current code behavior or pull requests that will fix them labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them tests needed Pull requests that need tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants