-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [CLI] Insert DBGroup variable in CLI validate method #8762
base: develop
Are you sure you want to change the base?
Conversation
Please sign all commits.
|
Add test code.
|
@codeigniter4/core-team Is this a bug fix? |
This is a feature. But I'm confused why CLI has to know the database group for prompts. It feels out of place here. |
I I'm doing the secure commit but it doesn't detect it |
@daycry What do you mean? What did you do exactly? |
|
@daycry Why do you need to add this? |
If you want validate rules with another database, you cant It, because now
you cant pass DBGroup variable in prompt función.
…On Thu, 11 Apr 2024, 12:12 kenjis, ***@***.***> wrote:
@daycry <https://github.com/daycry> Why do you need to add this?
—
Reply to this email directly, view it on GitHub
<#8762 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ5DP34BQJNEUNMJPHI33TY4ZOZNAVCNFSM6AAAAABGB3Y6R6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZGM3DIOBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@daycry Okay, but this is an enhancement. So please change the base branch to |
@paulbalandan The database group is a part of the validation rules. I have a feeling that it would be better to set up the following: |
I wan't pass DB connection instance, only DBGroup name, but I will try this. is_unique[table.field,ignore_field,ignore_value,db_group] Thanks |
Description
Allow a different DBGroup to be added in CLI class validations.
Checklist: