Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View report screen - Add moderator details (only when moderator is logged in) #193

Open
schlos opened this issue Jun 7, 2023 · 2 comments
Labels
🕷️ bug Something isn't working enhancement New feature or request help wanted Extra attention is needed html/css

Comments

@schlos
Copy link
Member

schlos commented Jun 7, 2023

Describe the bug

Pull Request:
https://github.com/codeforcroatia/popravi.to/pull/192/files#diff-f350cb961a82551ba528513c980939ae22f38f34756247bd8c178e147f28da16R55

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

For category and sub-category we need to implement these conditions like shown on this sub-template from parent repo:
https://github.com/mysociety/fixmystreet/blob/v3.1/templates/web/base/report/new/category_wrapper.html
and
https://github.com/mysociety/fixmystreet/blob/v3.1/templates/web/base/report/new/category.html
and
https://github.com/mysociety/fixmystreet/blob/v3.1/templates/web/base/report/new/_category_select.html
and all sub-nested templates they have under category from pages above.

You can also follow the same patch as in the example, i.e. create new file under:
templates/web/popravitodev/report/new/category.html with content same but design elements updated to our code. Since _category_select.html is included in their example, we need to add also that bit in our template. To make it easier, you can add that code snippet in place where they have "[%~ INCLUDE 'report/new/_category_select.html' ~%]" *replace this with _category_select.html content + apply our css for our design.

In this file (_main.html) in place where categories snippet has to be executed, add this:
[% PROCESS "report/new/category_wrapper.html" %]
like shown in their example here:
https://github.com/mysociety/fixmystreet/blob/v3.1/templates/web/base/report/new/form_report.html#L16

Ping me if you need more infos.

p.s. fix for this can be included in the next Pull Request as I will merge this one.

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Contribution guidelines: https://codeforcroatia.org/popravito-contribution-guidelines

@schlos schlos added 🕷️ bug Something isn't working html/css labels Jun 7, 2023
@schlos
Copy link
Member Author

schlos commented Jun 12, 2023

Before change:

Screenshot from 2023-06-12 09-45-55

After change:

Screenshot from 2023-06-12 09-46-06

For comparison, this is current production theme:

Screenshot from 2023-06-12 09-53-20

@schlos schlos changed the title Sub-categories IFs fix View report screen - Sub-categories IFs fix Jun 12, 2023
@schlos schlos changed the title View report screen - Sub-categories IFs fix View report screen - Fix metadata on view screen, add moderator screen Jun 12, 2023
@schlos schlos assigned schlos and unassigned znmustic Jun 12, 2023
@schlos
Copy link
Member Author

schlos commented Jun 12, 2023

I'll take a look at this later on.

@schlos schlos changed the title View report screen - Fix metadata on view screen, add moderator screen View report screen - Add moderator details (only when moderator is logged in) Jun 12, 2023
@schlos schlos removed their assignment Jun 12, 2023
@schlos schlos added enhancement New feature or request 🕷️ bug Something isn't working help wanted Extra attention is needed and removed 🕷️ bug Something isn't working labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working enhancement New feature or request help wanted Extra attention is needed html/css
Projects
None yet
Development

No branches or pull requests

2 participants