Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing report metadata on Report Details screen #179

Open
schlos opened this issue Dec 2, 2021 · 6 comments
Open

Add missing report metadata on Report Details screen #179

schlos opened this issue Dec 2, 2021 · 6 comments
Assignees
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css

Comments

@schlos
Copy link
Member

schlos commented Dec 2, 2021

Describe the bug

Missing report metadata on Report Details screen as per screenshots.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Add missing report metadata on Report Details screen.

Screenshots

Current:
Screenshot from 2021-12-02 08-07-50

Comparison with a different theme:
photo_2021-12-02_08-06-04

Expected:
Figma design screen - https://www.figma.com/proto/OrvZfg5BsfdOzeL7nhRpEI/Popravi.to?node-id=3171%3A11518&scaling=min-zoom&page-id=25%3A186&hide-ui=1

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Contribution guidelines: https://codeforcroatia.org/popravito-contribution-guidelines

@schlos schlos added the 🕷️ bug Something isn't working label Dec 2, 2021
@schlos schlos self-assigned this Dec 12, 2021
schlos added a commit that referenced this issue Dec 12, 2021
@schlos
Copy link
Member Author

schlos commented Dec 12, 2021

Temporary added.
It still needs to be displayed as per Figma.

@schlos schlos added help wanted Extra attention is needed html/css labels Dec 12, 2021
@schlos schlos removed their assignment Dec 12, 2021
@znmustic
Copy link

Pozdrav, ovo preuzimam na sebe @schlos .

@schlos
Copy link
Member Author

schlos commented May 11, 2023

Odlično, hvala!

Piši ako trebaš dodatno informacija.

@schlos
Copy link
Member Author

schlos commented Jun 12, 2023

As discussed after change done via pull request #192, we need to display moderator view only when moderator is logged in (to be done via #193).

Fix for this issue is done - design is applied.

Bug found during the testing that needs fixing:

  • current metadata shown when user reports a problem on popravitodev: we show real applicant name, but where applicant choose to be anynomous, we need to redact the name for not logged in user and other rules

Screenshot from 2023-06-12 10-31-14

@schlos
Copy link
Member Author

schlos commented Jun 12, 2023

@znmustic no need for you to do anything. I'll take a look how to apply rules for user anonymity.

@schlos schlos self-assigned this Jun 12, 2023
@schlos
Copy link
Member Author

schlos commented Jun 12, 2023

Noticed that Report Title is also missing (i.e. "Rupa na cesti" in the Figma design screen) and "Ažuriranja" section text.

Screenshot: https://app.snippyly.com/discuss/?q=E9rxGmdrwtoydD2348jP &EDIT=mfmrn40YrbzdFhpbNyXV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css
Projects
Development

No branches or pull requests

2 participants