Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCAP-50-FAQ-Screen #248

Merged
merged 4 commits into from May 14, 2024
Merged

CCAP-50-FAQ-Screen #248

merged 4 commits into from May 14, 2024

Conversation

enyia21
Copy link
Contributor

@enyia21 enyia21 commented May 10, 2024

πŸ”— Jira ticket

✍️ Description

πŸ“· Design reference

βœ… Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-50-create-f-gqgsn2 May 10, 2024 21:06 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-50-create-f-gqgsn2 May 13, 2024 14:42 Inactive
@enyia21 enyia21 marked this pull request as ready for review May 13, 2024 14:52
@github-actions github-actions bot requested a review from coltborg May 13, 2024 14:52
@enyia21 enyia21 changed the title WIP FAQ and messages.properties FAQ screen May 13, 2024
@enyia21 enyia21 changed the title FAQ screen CCAP-50-FAQ-Screen May 13, 2024
<a href="#when-selected" th:text="#{faq.when-selected.title}"></a>
</div>
</section>
<div class="grid">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .grid needs to be wrapped in it's own section so that it has consistent space.

For example here's the FAQ page next to the Privacy Policy page:
2024-05-13 at 16 50 58@2x

Copy link
Contributor

@coltborg coltborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment regarding spacing because of the missing section

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-50-create-f-gqgsn2 May 13, 2024 22:52 Inactive
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-50-create-f-gqgsn2 May 13, 2024 22:59 Inactive
Copy link
Contributor

@coltborg coltborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as I expected, once the tests pass, this is good to go.

@enyia21 enyia21 merged commit a222d0a into main May 14, 2024
5 checks passed
@enyia21 enyia21 deleted the CCAP-50-Create-FAQ-screen branch May 14, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants