Implement basic doc upload page and tests #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
commented
May 8, 2024
analoo
commented
May 8, 2024
| nextScreens: | ||
| - name: doc-upload-confirm | ||
| doc-upload-confirm: | ||
| condition: SkipTemplate |
There was a problem hiding this comment.
removed skip template because otherwise there is no nextScreen for doc-upload-add-files
analoo
commented
May 8, 2024
| doc-upload-add-files.header=Upload documents | ||
| doc-upload-add-files.accordion-1.title=Recommended documents | ||
| doc-upload-add-files.accordion-1.p1=Share documents that verify: | ||
| doc-upload-add-files.accordion-1.body1= <strong>Parent jobs and income</strong><br/>Add two recent pay stubs or an income verification letter for each working parent. |
There was a problem hiding this comment.
Added each paragraph in its separate string just in case there are copy changes: It will affect a smaller grouping of words rather than all the text.
analoo
commented
May 8, 2024
| @@ -105,12 +103,30 @@ protected void uploadFile(String filepath, String dzName) { | |||
| .isBlank()); | |||
| } | |||
|
|
|||
| protected void uploadFile(String filepath) { | |||
There was a problem hiding this comment.
There are similar methods with different signatures that may be tied to drag and drop.
enyia21
requested changes
May 9, 2024
| <p th:utext="#{doc-upload-add-files.accordion-1.body5}"></p> | ||
| </th:block> | ||
| </th:block> | ||
| <th:block th:replace="~{fragments/fileUploader :: fileUploader(inputName='uploadDocuments')}"></th:block> |
There was a problem hiding this comment.
The file uploader implementation should be implemented in the next ticket. Not a problem now, in my opinion
analoo
force-pushed
the
CCAP-33-doc-upload-basic-screens
branch
from
ac78a1b
to
e0b0a41
Compare
analoo
force-pushed
the
CCAP-33-doc-upload-basic-screens
branch
from
f5f6ff6
to
3bfe2b1
Compare
analoo
force-pushed
the
CCAP-33-doc-upload-basic-screens
branch
from
69a8a24
to
84c8e36
Compare
enyia21
requested changes
May 13, 2024
| <p th:utext="#{doc-upload-recommended-docs.school.body}"></p> | ||
|
|
||
| <th:block th:replace="~{fragments/gcc-icons :: job}"></th:block> | ||
| <p th:utext="#{doc-upload-recommended-docs.school.body}"></p> |
There was a problem hiding this comment.
I think you meant to doc-upload-recommended-docs.training.body instead of doc-upload-recommended-docs.school.body.
enyia21
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
Issue Link
✍️ Description
📷 Design reference
Figma Design
✅ Completion tasks
Note: If you are testing this locally, you will need to copy over staging AWS credentials.