GUI-Instagram-Downloader #25
Conversation
|
@Bobliuuu |
There was a problem hiding this comment.
Hi @Abubakrce19, thank you for your PR. The code looks great 🎉
However, since our project tutorial is for the Codédex site, you shouldn't link to another site, and instead just put the explanation in the mdx file.
Looking at your Medium article though, it seems like you are showing people how to use your code. The project tutorial should explain the code, not just how to use it. You should explain each part of your code and what it does.
Please let me know if you have any questions!
|
Here is a reference tutorial: https://www.codedex.io/projects/generate-a-qr-code-with-python In this tutorial, the lines of code are explained, not just how to use the code. |
Sorry for that I will remove the link. Plus I have explained each line of code using comments in code.Is'nt it enough? Or still It is better to explain code separately? Thank you!! |
|
@Bobliuuu |
There was a problem hiding this comment.
Hi @Abubakrce19, nice work! However, there are still some issues:
- In your code, please keep formatting consistent. This means spaces before commas but not after, either spaces or no spaces after equal signs (but not both), and no spaces before
: - Your code needs to be explained a lot more. Since this is a project tutorial, you should go into your code in depth: you need to explain more about what each block of code does, and how it fits into the entire flow of your code
- For example, I would talk about what each module does, and what an
InstaLoader()does, what Threading is, etc. - The tutorial should be written in a way that anyone with basic Python knowledge can understand the code
- Please refer to @asiqurrahman's project tutorial, where he goes into depth about each code block and what it does: https://www.codedex.io/projects/generate-a-blog-with-openai
- Please elaborate on your introduction and add a conclusion, and review your tutorial so there are no typos (e.g. ## Explanation, not ## Explaination)
|
Thank you for your valuable suggestions. |
|
No problem! When you are done, please re-request my review. |
| </p> | ||
|
|
||
| ## Explanation | ||
| <p> Import the required Libraries and Modules </P> |
There was a problem hiding this comment.
Please explain each library and module (and lowercase "libraries" and "modules")
| import os | ||
| ``` | ||
|
|
||
| <p>function for downloading User profile picture </p> |
There was a problem hiding this comment.
Explain what filedialog.askdirectory() is, and what the Instaloader() code does in more detail
| threading.Thread(target = download_image).start() | ||
| ``` | ||
|
|
||
| <p> Function for downloading image by URL</P> |
There was a problem hiding this comment.
Here, talk about logging into Instagram and how that works with the instaloader
| try : | ||
| L.login(Username,Password) | ||
| except : | ||
| messagebox.showerror('ERROR','Username or Password is Wrong') |
There was a problem hiding this comment.
Make this a separate code block and explanation of messagebox
| ``` | ||
|
|
||
|
|
||
| <p> To create a tkinter GUI frame</p> |
There was a problem hiding this comment.
Expand about Tinkter here. What exactly does it do? Why do we need it in this project?
| messagebox.showerror('Error','You have to enter your Username and Password') | ||
| ``` | ||
|
|
||
| The new_window function |
There was a problem hiding this comment.
Why do we need the new_window function? How does it fit into the project flow?
|
@Abubakrce19 Great work! Please review the comments I made, and make the changes.
|
|
Sure |
|
Hi @Abubakrce19, great job on the progress so far! Love the project idea. After chatting with the team, I think we can merge this in and workshop it a bit more internally. What do you think? Also can you give me your name and email so I can send you a Discord invite? Thanks! 🙏 |
|
Sure go ahead @sonnynomnom . |
|
Plus I have finals nearby, I will try to add more details after final. |
|
@sonnynomnom |
Closes issue
#18
GUI-Insta-Downloader
Graphical User Interface Instagram Downloader
Introduction
As Instagram does not provide any download option for thier posts(reels/profile picture/images), here is a Gui based Instagram downloader.
Requirements
Features
How to Install
Introduction
As Instagram does not provide any download option for thier posts(reels/profile picture/images), here is a Gui based Instagram downloader.
Please consult Project tutorial for more detail.
mdx