Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add mypy (optional) #437

Merged
merged 1 commit into from May 16, 2024
Merged

build: add mypy (optional) #437

merged 1 commit into from May 16, 2024

Conversation

joseph-sentry
Copy link
Contributor

add mypy checking in pre commit and CI

@codecov-notifications
Copy link

codecov-notifications bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33607    33607           
=======================================
  Hits        32715    32715           
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (966d2e8) to head (fbdfc85).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33607    33607           
=======================================
  Hits        32715    32715           
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (966d2e8) to head (fbdfc85).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         430      430           
  Lines       34297    34297           
=======================================
  Hits        33396    33396           
  Misses        901      901           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.60% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

This change has been scanned for critical changes. Learn more

Copy link

codecov-public-qa bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (966d2e8) to head (fbdfc85).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         399      399           
  Lines       33607    33607           
=======================================
  Hits        32715    32715           
  Misses        892      892           
Flag Coverage Δ
integration 97.34% <ø> (ø)
latest-uploader-overall 97.34% <ø> (ø)
unit 97.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.50% <ø> (ø)

@joseph-sentry joseph-sentry added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 0862b20 May 16, 2024
30 checks passed
@joseph-sentry joseph-sentry deleted the joseph/mypy branch May 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants