[React] Post a resource #55

lpatmo · 2019-11-06T05:38:06Z

Is your feature request related to a problem? Please describe.
Mock posting a resource from https://cb-react-concept.netlify.com/submit-resource

See: https://egghead.io/lessons/javascript-creating-demo-apis-with-json-server

Describe the solution you'd like

User fills out the fields and clicks on "submit", and sees a success message
User is redirected to /resources
User sees the new resource they added

Essentially, we need to explore making a fake POST request to the /resources API endpoint.

peoray · 2019-11-17T20:12:57Z

@lpatmo have you seen this?
https://fakejson.com/

lpatmo · 2019-11-17T21:50:18Z

@peoray We're using https://github.com/typicode/json-server right now, which is similar, except our DB lives in db.json flie. :)

I've got most of the steps working in the branch issue-55, but haven't had time to do form validation and display the success message yet. Feel free to take a look if you're interested!

peoray · 2019-11-19T15:53:21Z

Cool, will definitely take a look. Is it possible for two people to work on the same branch?

wuworkshop · 2019-11-25T17:53:24Z

@peoray Sorry for the late reply. Yes, it is possible for two people to work on the same branch. Since @lpatmo pushed her branch up to GitHub here https://github.com/codebuddies/react-concept/tree/issue-55, you should be able to checkout that branch and work on it.

peoray · 2019-11-30T14:15:53Z

I'm trying to do this but it doesn't work

alomo@alomo:~/Documents/code/oss/react-concept$ git checkout issue-55
error: pathspec 'issue-55' did not match any file(s) known to git

Btw, my repo is up to date with the main repo

lpatmo · 2019-11-30T18:32:40Z

Sorry about that. Will take a look when I get back to my computer tonight!

…

On Sat, Nov 30, 2019, 9:15 AM Emmanuel Raymond ***@***.***> wrote: I'm trying to do this but it doesn't work ***@***.***:~/Documents/code/oss/react-concept$ git checkout issue-55 error: pathspec 'issue-55' did not match any file(s) known to git Btw, my repo is up to date with the main repo — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCNXOYS2AF7ISTTTI767HTQWJYRVANCNFSM4JJP4J3Q> .

lpatmo · 2019-12-01T00:38:07Z

@peoray Does typing git remote -v already point to an upstream that's this repo? You'll probably have to git fetch upstream before you can check out the branch. Let me know if that works!

peoray · 2019-12-02T13:01:18Z

I already have it as an upstream and I'm using pull instead of fetch, does that mean a difference?

lpatmo · 2019-12-19T07:47:36Z

@peoray Sorry I missed your comment! Can you share what you see when you type git remote -v? Or did you already figure this out?

peoray · 2019-12-19T12:31:36Z

alomo@alomo:~/Documents/code/oss/react-concept$ grv
origin	https://github.com/peoray/react-concept.git (fetch)
origin	https://github.com/peoray/react-concept.git (push)
upstream	https://github.com/codebuddies/react-concept.git (fetch)
upstream	https://github.com/codebuddies/react-concept.git (push)
alomo@alomo:~/Documents/code/oss/react-concept$

lpatmo · 2019-12-20T01:46:55Z

@peoray I think if you git pull upstream and then git checkout issue-55 you should be able to see the branch.

peoray · 2019-12-20T11:00:41Z

Still not working...:(

lpatmo · 2019-12-22T07:05:47Z

@peoray Thanks for sharing those screenshots! Can you try git checkout origin/issue-55?

peoray · 2019-12-22T12:04:01Z

Still doesn't work. Still not sure if the issue is from my side or not. I'd love for someone else to try and see if it will work on their end

wuworkshop · 2019-12-23T03:17:36Z

@peoray Looking at your screenshots, you didn't quite follow exactly what @lpatmo had written. She wrote git pull upstream. In your screenshot, you wrote git pull upstream master. Adding the master part will only pull in changes from upstream's master branch.

I just tested this out in my own fork. Here are the exact steps to follow to update your fork with all the branches in the upstream repo:

git fetch upstream
This will fetch ALL the branches from the upstream repo. When you run this command, you should see a longer list of branches as a result.
git checkout master
Then checkout your fork's local master branch.
git merge upstream/master
This will merge the changes from upstream/master into your local master branch. This brings your fork's master branch into sync with the upstream repository, without losing your local changes.
git branch -r
To verify you now have the issue-55 branch, the -r flag will list all remote branches. You should see issue-55 under origin and upstream.
git checkout --track origin/issue-55
To checkout the issue-55 branch.
git push origin master
To push the changes to your fork on GitHub.

References:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

wuworkshop · 2019-12-23T03:22:46Z

@peoray btw, since you asked this question:

I'm using pull instead of fetch, does that mean a difference?

There is actually a difference between git pull and git fetch.

git pull is shorthand for git fetch followed by git merge FETCH_HEAD.
More precisely, git pull runs git fetch with the given parameters and calls git merge to merge the retrieved branch heads into the current branch.

References:
https://git-scm.com/docs/git-pull

peoray · 2019-12-23T15:54:36Z

Thank you @wuworkshop. That was the problem. It's working now :)

peoray · 2019-12-23T16:15:38Z

@lpatmo What do you have in mind as regards how to handle the validation?

lpatmo · 2019-12-24T09:21:45Z

@peoray I'm thinking of using react-form-hooks, based on this article:
https://blog.logrocket.com/react-hook-form-vs-formik-a-technical-and-performance-comparison/

A relevant thread: mui/material-ui#18269

I'm actually curious if anyone else has recommendations for validation with Material-UI too!

peoray · 2020-01-01T22:01:20Z

Okay. If this is fine with everyone, I'd like to start working on this issue

sebbel · 2020-01-31T19:45:00Z

@peoray hey do you need help to get started? We could pair on this if you'd like :)

peoray · 2020-02-01T15:11:11Z

@sebbel that would be awesome. Just sent you a message on slack :)

lpatmo · 2020-07-26T19:44:55Z

@bkbuilt and I paired on this on Twitch earlier today: https://www.twitch.tv/videos/691444610

We jotted down a couple of TODOs we'll tackle in a future pairing session, including:

// TODO : // when type, store values on change // decide what happens on successful submit (redirect to created resource, alert like "congrats you submitted resource..") // validation (follow auth implementation) (as type, post-submit) // display failed submissions to the user (if not already) // test for posting to mock up successful response // ensure these are all desired fields for forms

stale · 2020-09-06T05:05:07Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tgrrr · 2020-09-09T03:27:18Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Bump because I think this is an open ongoing issue

What: submitResource.js: - fix console errors: name missing in url component. Fixed with name in `ref` on line 172 - add defaultValues: initialState - refactor initialState - add button type submit - cleaned up db.json ResourceCard: - fix Card class -> className - update `created` PropTypes Note: this will fail if an invalid date is submitted to db.json (validation is yet to be done) Why: - No more console errors - Now generates errors on fields that are required or have validation - Submits form to populate db.json - [x] User fills out the fields and clicks on "submit", - [ ] user sees a success message - [x] User is redirected to /resources - [x] User sees the new resource they added Note: The user doesn't see a success message, because they are redirected too quickly Still to complete: - [ ] Validation - [ ] unit tests - [ ] e2e tests #55

tgrrr · 2020-09-09T12:03:35Z

I got on top of the bugs for this Linda @lpatmo. It still needs more work, including validation and tests to be written.

lpatmo · 2020-09-10T01:40:29Z

Thanks so much for taking a look! Will take a look at the issue-55 branch (where I assume you made the commits)

lpatmo · 2020-09-10T02:13:53Z

@tgrrr So sorry again about the confusion with the branches! I probably should have deleted issue-55. issue55-post contains the more updated work involving useReducer and the React Query refactor and the validation that a user is logged in before they can post. I'll dig into it again on stream sometime.

stale · 2020-10-13T20:33:34Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

lpatmo self-assigned this Nov 11, 2019

BethanyG assigned BethanyG and unassigned BethanyG Dec 25, 2019

billglover added this to To do in CodeBuddies Feb 15, 2020

angelocordon added this to To do in v30.1 Mar 1, 2020

angelocordon added this to the v3.0.1 milestone Mar 1, 2020

angelocordon added this to To do in Resources Mar 1, 2020

lpatmo mentioned this issue Apr 1, 2020

Add Form Validations to AuthForms #93

Closed

lpatmo added the priority label Jul 26, 2020

lpatmo assigned bkbuilt Jul 26, 2020

lpatmo added the in progress label Jul 26, 2020

lpatmo added high-priority and removed priority labels Aug 7, 2020

lpatmo added this to High priority in V3 Priorities Aug 23, 2020

stale bot added the stale label Sep 6, 2020

stale bot removed the stale label Sep 9, 2020

tgrrr self-assigned this Sep 9, 2020

angelocordon moved this from High priority to High Priority In Progress in V3 Priorities Sep 12, 2020

lpatmo unassigned tgrrr Sep 12, 2020

lpatmo mentioned this issue Sep 13, 2020

[Draft] [Issue-55] Submit a resource #154

Closed

14 tasks

angelocordon self-assigned this Sep 13, 2020

angelocordon added the claimed label Sep 13, 2020

stale bot added the stale label Oct 13, 2020

stale bot closed this as completed Oct 20, 2020

CodeBuddies automation moved this from To do to Done Oct 20, 2020

Resources automation moved this from To do to Done Oct 20, 2020

V3 Priorities automation moved this from High Priority In Progress to Done Oct 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[React] Post a resource #55

[React] Post a resource #55

lpatmo commented Nov 6, 2019

peoray commented Nov 17, 2019 •

edited

lpatmo commented Nov 17, 2019

peoray commented Nov 19, 2019

wuworkshop commented Nov 25, 2019

peoray commented Nov 30, 2019

lpatmo commented Nov 30, 2019 via email

lpatmo commented Dec 1, 2019 •

edited

peoray commented Dec 2, 2019

lpatmo commented Dec 19, 2019

peoray commented Dec 19, 2019

lpatmo commented Dec 20, 2019

peoray commented Dec 20, 2019

lpatmo commented Dec 22, 2019

peoray commented Dec 22, 2019

wuworkshop commented Dec 23, 2019

wuworkshop commented Dec 23, 2019

peoray commented Dec 23, 2019

peoray commented Dec 23, 2019

lpatmo commented Dec 24, 2019

peoray commented Jan 1, 2020

sebbel commented Jan 31, 2020

peoray commented Feb 1, 2020

lpatmo commented Jul 26, 2020

stale bot commented Sep 6, 2020

tgrrr commented Sep 9, 2020

tgrrr commented Sep 9, 2020

lpatmo commented Sep 10, 2020

lpatmo commented Sep 10, 2020

stale bot commented Oct 13, 2020

[React] Post a resource #55

[React] Post a resource #55

Comments

lpatmo commented Nov 6, 2019

peoray commented Nov 17, 2019 • edited

lpatmo commented Nov 17, 2019

peoray commented Nov 19, 2019

wuworkshop commented Nov 25, 2019

peoray commented Nov 30, 2019

lpatmo commented Nov 30, 2019 via email

lpatmo commented Dec 1, 2019 • edited

peoray commented Dec 2, 2019

lpatmo commented Dec 19, 2019

peoray commented Dec 19, 2019

lpatmo commented Dec 20, 2019

peoray commented Dec 20, 2019

lpatmo commented Dec 22, 2019

peoray commented Dec 22, 2019

wuworkshop commented Dec 23, 2019

wuworkshop commented Dec 23, 2019

peoray commented Dec 23, 2019

peoray commented Dec 23, 2019

lpatmo commented Dec 24, 2019

peoray commented Jan 1, 2020

sebbel commented Jan 31, 2020

peoray commented Feb 1, 2020

lpatmo commented Jul 26, 2020

stale bot commented Sep 6, 2020

tgrrr commented Sep 9, 2020

tgrrr commented Sep 9, 2020

lpatmo commented Sep 10, 2020

lpatmo commented Sep 10, 2020

stale bot commented Oct 13, 2020

peoray commented Nov 17, 2019 •

edited

lpatmo commented Dec 1, 2019 •

edited