Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Form Validations to AuthForms #93

Closed
angelocordon opened this issue Mar 8, 2020 · 3 comments · Fixed by #105
Closed

Add Form Validations to AuthForms #93

angelocordon opened this issue Mar 8, 2020 · 3 comments · Fixed by #105
Assignees
@peoray
Labels
claimed priority
Projects
Basic Auth
Milestone
v3.0.1

Comments

@angelocordon
Copy link
Contributor

Auth Forms should validate required fields and types based on what the API expects to have.
@angelocordon angelocordon created this issue from a note in Basic Auth (To do) Mar 8, 2020
@angelocordon angelocordon added this to the v3.0.1 milestone Mar 8, 2020
@angelocordon angelocordon added help wanted Extra attention is needed priority labels Mar 8, 2020
@peoray peoray self-assigned this Mar 10, 2020
@lpatmo
Copy link
Member

lpatmo commented Apr 1, 2020 •
edited

Cross-posting a comment I made in #55 re: validation libraries --

I'm thinking we could use react-form-hooks, based on this article:
https://blog.logrocket.com/react-hook-form-vs-formik-a-technical-and-performance-comparison/

A relevant thread: mui/material-ui#18269

Was curious if anyone else had recommendations for validation with Material-UI too! I asked this on Slack in the #reactjs channel, and got Formik (https://github.com/jaredpalmer/formik).

@peoray peoray closed this as completed Apr 1, 2020
Basic Auth automation moved this from To do to Done Apr 1, 2020
@peoray peoray reopened this Apr 1, 2020
Basic Auth automation moved this from Done to In progress Apr 1, 2020
@peoray
Copy link
Member

peoray commented Apr 1, 2020

I'm familiar with Formik and Yup. Which one should I go on with. React hooks form looks promising also.

@angelocordon
Copy link
Contributor Author

Based on that blog post from @lpatmo, I'm inclined to lean in on React Hook Form. I haven't played around with it yet, but might be worth experimenting with it @peoray 👍

@gauravchl gauravchl mentioned this issue Apr 22, 2020
Merged
1 task
@sebbel sebbel added claimed and removed help wanted Extra attention is needed labels Apr 24, 2020
@angelocordon angelocordon linked a pull request Apr 26, 2020 that will close this issue
Add form validations #105
Merged
1 task
Basic Auth automation moved this from In progress to Done Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peoray peoray

Labels
claimed priority
Projects
Basic Auth
  
Done
Milestone
v3.0.1
Development

Successfully merging a pull request may close this issue.

Add form validations codebuddies/frontend
4 participants
@sebbel @angelocordon @lpatmo @peoray